[SDL] Freescale i.MX6 video driver

mastermind denis.barkar at gmail.com
Thu Sep 11 05:00:50 PDT 2014


Hi! I've already fixed this issue few days before - https://github.com/mastermind-/SDL-mx6/commit/99ecdd7ecc2ffac300ef8e9b200e2c829cb619e1.patch
I've found error in your patch: in MX6_GLES_LoadLibrary you are calling eglGetDisplay with native_display which is not initialized yet (it will be filled in MX6_UpdateDisplay later) and egl_display will be invalid. Although It may work on some cases when eglGetDisplay(0) returns valid egl_display, but fbGetDisplayByIndex can return non-zero value (in my case).
Please apply my patch, it's tested and now in production :)



Sam Lantinga wrote:
> Okay, this patch is in SDL, thanks!
> 
> I added an additional change so the correct desktop video mode is reported.
> 
> Cheers!
> 
> 
> On Fri, Aug 29, 2014 at 6:52 AM, mastermind <denis.barkar at gmail.com (denis.barkar at gmail.com)> wrote:
> 
> >  	 	Didn't know about this patch.
> > Nice work, but mine is little better [Image: http://forums.libsdl.org/images/smiles/icon_smile.gif ]
> > 1) Loads EGL library dinamically. In theory it can be compiled with X/directfb/wayland drivers too, they will share EGL native types definitions, which are binary compatible. Ideally, SDL_egl.c should be compiled separately for every driver.
> > 2) Doesn't have code garbage from rpi driver [Image: http://forums.libsdl.org/images/smiles/icon_smile.gif ]
> > 3) Build using cmake
> > 
> > Btw, it doesn't 100% fit to common "SOC" backend because to load EGL library using SDL_GL_LoadLibrary it should get native display using function from this library [Image: http://forums.libsdl.org/images/smiles/icon_smile.gif ] That's why I had to reimplement SDL_GL_LoadLibrary.
> > 
> > 
> > 
> > 
> > 	gabomdq wrote:
> > 
> > 	There's another related patch here: https://bugzilla.libsdl.org/show_bug.cgi?id=2386 (https://bugzilla.libsdl.org/show_bug.cgi?id=2386)
> > 
> > I think we need to figure out a way to consolidate these under a "SOC" backend, or risk having a ton of 99% similar backends, and that will become a support nightmare.
> > 
> > 
> > 2014-08-29 10:07 GMT-03:00 mastermind <>:
> > 
> > 
> > 
> > 	Quote:
> > 
> > 	  	 	You can get patches from github:
> > https://github.com/mastermind-/SDL-mx6/commit/5e64a9fffb73192c0e56fbf300cbbfd7081dc16d.patch (https://github.com/mastermind-/SDL-mx6/commit/5e64a9fffb73192c0e56fbf300cbbfd7081dc16d.patch) - master
> > https://github.com/mastermind-/SDL-mx6/commit/73681170adcb7330f41044c1b82857f4bcdd6006.patch (https://github.com/mastermind-/SDL-mx6/commit/73681170adcb7330f41044c1b82857f4bcdd6006.patch) - 2.0.3
> > 	
> > 
> > _______________________________________________
> > SDL mailing list
> > 
> > http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org (http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org)
> > 
> > 
> > 	
> > 
> > 
> > 
> > 
> > 
> > -- 
> > Gabriel.
> > 	
> > 
> > 
> > 	
> > 
> > _______________________________________________
> > SDL mailing list
> > SDL at lists.libsdl.org (SDL at lists.libsdl.org)
> > http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org (http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org)
> > 
> > 
> 





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.libsdl.org/pipermail/sdl-libsdl.org/attachments/20140911/be07f585/attachment-0002.htm>


More information about the SDL mailing list