[SDL] Cleanup #include Windows.h proposal

[GMScribe]

Hi guys,

I've been trying to integrate some code of mine into SDL and have discovered
that just by including SDL_opengl.h in SDL_sysvideo.h it brings up just
under 100 warnings and errors. I've decided that it appears to be the early
including of windows.h that is done in SDL_opengl.h and sure enough, moving
some of the defines over from sysvideo reduces the error count. However
these are still some errors that I can assume are from other windows
includes in other files where I've not copied over their defines to
SDL_opengl.h.

I would like to propose that we consolidate the setting up of windows
defines and the including of windows.h into SDL_config_win32.h, as almost
every sdl file includes SDL_config.h (and thus config_win32) as the very
first line of code. Ultimately windows.h is only going to get included once
so it'll be a good idea for us to have control over when and be able to see
all the defines in one location. This will help clear clutter from files
that distract from the functional code and hopefully make future
modifications easier by lessening the volatility of including windows.h out
of order.

Does this proposal sound reasonable? If so I'll look into making the
changes. I suspect that similar measures could be taken for x11 etc as well.

Many thanks.
-- 
View this message in context: http://www.nabble.com/Cleanup--include-Windows.h-proposal-tp24927834p24927834.html
Sent from the SDL mailing list archive at Nabble.com.