[SDL] Re: New driver for OpenBSD/wscons

Ryan C. Gordon icculus at icculus.org
Mon Nov 21 22:58:29 PST 2005


>>>I asked how to submit the driver a few days ago, and posted a link to
>>>the patch in a follow-up, so maybe it was missed?
>>
>>It wasn't missed; examining it is on my TODO list.
> 
> Ok, good!

Patch looks pretty good, just two questions:

You added this in the joystick code:

-#if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__OpenBSD__)
+#if defined(__FreeBSD__) || defined(__NetBSD__) || 
(defined(__OpenBSD__) && defined(__i386__))


Is there any reason that piece of code is x86 specific? Does that 
interface only exist as a legacy thing on OpenBSD/x86?


Also, the configure.in script added this:

+        AC_MSG_CHECKING(for wscons support)
+        video_wscons=no
+        AC_LANG_C
+        AC_TRY_COMPILE([
+       #include <sys/time.h>
+       #include <dev/wscons/wsconsio.h>
+        ],[
+        ],[
+        video_wscons=yes
+        ])
+



...it looks like you are only concerned with the existence of 
wsconsio.h...can we just use AC_CHECK_HEADER instead?

Let me know and I'll commit this to CVS.

Thanks,
--ryan.





More information about the SDL mailing list